Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Test GitHub scrape function, update mock server and tests accordingly #203

Merged
merged 7 commits into from
Nov 15, 2023

Conversation

rhoofard
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the go label Nov 14, 2023
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (50d6015) 45.50% compared to head (6e9b086) 61.44%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #203       +/-   ##
===========================================
+ Coverage   45.50%   61.44%   +15.94%     
===========================================
  Files           9        9               
  Lines         690      690               
===========================================
+ Hits          314      424      +110     
+ Misses        368      242      -126     
- Partials        8       24       +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rhoofard rhoofard changed the title Test GitHub scrape function, update mock server and tests accordingly test: Test GitHub scrape function, update mock server and tests accordingly Nov 14, 2023
@adrielp adrielp marked this pull request as ready for review November 14, 2023 21:18
@adrielp adrielp requested a review from a team as a code owner November 14, 2023 21:18
Copy link
Collaborator

@adrielp adrielp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. merge when the last checks are fixed

@rhoofard rhoofard merged commit 68bc840 into main Nov 15, 2023
10 checks passed
@rhoofard rhoofard deleted the test-github-scrape branch November 15, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants