test: add tests for config.go #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsshaddox
changed the title
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #144 +/- ##
==========================================
+ Coverage 25.50% 27.08% +1.58%
==========================================
Files 5 5
Lines 443 443
==========================================
+ Hits 113 120 +7
+ Misses 321 316 -5
+ Partials 9 7 -2 ☔ View full report in Codecov by Sentry. |
adrielp
reviewed
Oct 11, 2023
| args: args{componentParser: nil}, | ||
| wantErr: false, | ||
| }, | ||
| // { |
There was a problem hiding this comment.
We should add some additional test cases here. Let's merge this in and iterate on another tasks to add more test cases.
adrielp
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added a test for the invalid scraper key and a test to check for componentParser being nil.