Skip to content
This repository has been archived by the owner on Jul 14, 2023. It is now read-only.

Fix a corner case about quoted identifiers containing curly braces #32

Merged
merged 1 commit into from
May 4, 2020

Conversation

liancheng
Copy link
Owner

Previously, the fixedImporterSyntax method uses naive string replacements, which cannot handle quoted identifiers like `{ d }`. This PR fixes this corner case.

@codecov
Copy link

codecov bot commented May 4, 2020

Codecov Report

Merging #32 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #32   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           10        10           
=========================================
  Hits            10        10           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update becbc0c...4e88572. Read the comment docs.

@liancheng liancheng merged commit c7bb8d2 into master May 4, 2020
@liancheng liancheng added this to the v0.3.0 milestone May 7, 2020
@liancheng liancheng added the bug Something isn't working label May 7, 2020
@liancheng liancheng deleted the quoted-ident-with-braces branch May 7, 2020 10:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant