post-checkout hook always provides a third argument.

lhaggar · Apr 30, 2019 · 6318f32 · 6318f32
1 parent 7cc3448
commit 6318f32
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/package-change-checker.js b/src/package-change-checker.js
@@ -9,7 +9,7 @@ const defaultCommit2 = 'HEAD';
 const hasChangedDependencies = (commitish = []) => {
   let commit1 = defaultCommit1;
   let commit2 = defaultCommit2;
-  if (commitish.length === 2) {
+  if (commitish.length >= 2) {
     if (
       git.isValidCommitish(commitish[0]) &&
       git.isValidCommitish(commitish[1])

diff --git a/src/package-change-checker.spec.js b/src/package-change-checker.spec.js
@@ -213,6 +213,7 @@ describe('package-change-checker.js', () => {
         checker.hasChangedDependencies([
           'abcdef0123456789abcdef0123456789abcdef01',
           'abcdef0123456789abcdef0123456789abcdef02',
+          '1',
         ]);
       });
 
@@ -251,7 +252,7 @@ describe('package-change-checker.js', () => {
       });
 
       it('should use default commitish when two invalid commitish are provided', () => {
-        checker.hasChangedDependencies(['', '']);
+        checker.hasChangedDependencies(['', '', '1']);
         expect(git.isValidCommitish).to.have.been.calledOnceWithExactly('');
         expect(git.getDiff).to.have.been.calledOnceWithExactly(
           'ORIG_HEAD',
@@ -264,6 +265,7 @@ describe('package-change-checker.js', () => {
         checker.hasChangedDependencies([
           'abcdef0123456789abcdef0123456789abcdef01',
           '',
+          '1'
         ]);
         expect(git.isValidCommitish).to.have.been.calledTwice();
         expect(git.isValidCommitish).to.have.been.calledWithExactly(