Report errors mapping amino acids #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi Heng, Thanks for yet another brilliant tool! This patch reports errors mapping amino acid files to the reference. AFAICT, the only non-zero exit code of mp_map_file() is for errors opening the faa file(s). I hit this due to a stupid error on my part: giving `query.faa.gz` when only `query.faa` existed on disk. Miniprot ran fine but of course gave an empty gff. Now, the user should at least get a warning and a non-zero exit code in case of stupidity :) Best, Kevin
|
Make sense. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Heng,
Thanks for yet another brilliant tool!
This patch reports errors mapping amino acid files to the reference. AFAICT, the only non-zero exit code of mp_map_file() is for errors opening the faa file(s). I hit this due to a stupid error on my part: giving
query.faa.gzwhen onlyquery.faaexisted on disk. Miniprot ran fine but of course gave an empty gff. Now, the user should at least get a warning and a non-zero exit code in case of stupidity :)Best,
Kevin