Skip to content

Commit

Permalink
Remove default docker name value of swss. (sonic-net#692)
Browse files Browse the repository at this point in the history
* Remove default docker name value of swss.

The default docker name caused a lot of confusion when the libraries used in other dockers

Signed-off-by: Jipan Yang <[email protected]>

* [VS]: fix syncd crash caused by meta_generic_validation_remove reference count error

Signed-off-by: Jipan Yang <[email protected]>

* [vs]: user sysfs to get mac of server eth0

Signed-off-by: Jipan Yang <[email protected]>
  • Loading branch information
jipanyang authored and lguohan committed Nov 19, 2018
1 parent 067928d commit 28dc042
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 8 deletions.
4 changes: 2 additions & 2 deletions cfgmgr/vlanmgrd.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,8 @@ int main(int argc, char **argv)
DBConnector appDb(APPL_DB, DBConnector::DEFAULT_UNIXSOCKET, 0);
DBConnector stateDb(STATE_DB, DBConnector::DEFAULT_UNIXSOCKET, 0);

WarmStart::initialize("vlanmgrd");
WarmStart::checkWarmStart("vlanmgrd");
WarmStart::initialize("vlanmgrd", "swss");
WarmStart::checkWarmStart("vlanmgrd", "swss");

/*
* swss service starts after interfaces-config.service which will have
Expand Down
4 changes: 2 additions & 2 deletions orchagent/main.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -102,8 +102,8 @@ int main(int argc, char **argv)

SWSS_LOG_ENTER();

WarmStart::initialize("orchagent");
WarmStart::checkWarmStart("orchagent");
WarmStart::initialize("orchagent", "swss");
WarmStart::checkWarmStart("orchagent", "swss");

if (signal(SIGHUP, sighup_handler) == SIG_ERR)
{
Expand Down
4 changes: 2 additions & 2 deletions portsyncd/portsyncd.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,8 @@ int main(int argc, char **argv)
ProducerStateTable p(&appl_db, APP_PORT_TABLE_NAME);
SubscriberStateTable portCfg(&cfgDb, CFG_PORT_TABLE_NAME);

WarmStart::initialize("portsyncd");
WarmStart::checkWarmStart("portsyncd");
WarmStart::initialize("portsyncd", "swss");
WarmStart::checkWarmStart("portsyncd", "swss");
const bool warm = WarmStart::isWarmStart();

LinkSync sync(&appl_db, &state_db);
Expand Down
6 changes: 4 additions & 2 deletions tests/test_warm_reboot.py
Original file line number Diff line number Diff line change
Expand Up @@ -741,7 +741,8 @@ def test_OrchagentWarmRestartReadyCheck(dvs, testlog):
assert result == "RESTARTCHECK failed\n"

# Cleaning previously pushed route-entry to ease life of subsequent testcases.
del_entry_tbl(appl_db, swsscommon.APP_ROUTE_TABLE_NAME, "2.2.2.0/24")
ps._del("2.2.2.0/24")
time.sleep(1)

# recover for test cases after this one.
dvs.stop_swss()
Expand Down Expand Up @@ -1521,7 +1522,8 @@ def test_system_warmreboot_neighbor_syncup(dvs, testlog):
dvs.runcmd("ip -6 addr add {}00::1/64 dev Ethernet{}".format(i*4,i*4))
dvs.servers[i].runcmd("ip link set up dev eth0")
dvs.servers[i].runcmd("ip addr flush dev eth0")
result = dvs.servers[i].runcmd_output("ifconfig eth0 | grep HWaddr | awk '{print $NF}'")
#result = dvs.servers[i].runcmd_output("ifconfig eth0 | grep HWaddr | awk '{print $NF}'")
result = dvs.servers[i].runcmd_output("cat /sys/class/net/eth0/address")
macs.append(result.strip())

#
Expand Down

0 comments on commit 28dc042

Please sign in to comment.