Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we add "validated" to flag? #81

Closed
kensei-te opened this issue Apr 19, 2022 · 9 comments
Closed

Can we add "validated" to flag? #81

kensei-te opened this issue Apr 19, 2022 · 9 comments
Assignees
Labels
backend breaking change When the change might break the compatibility change in data db The issue requires a change in the data stored in db difficult frontend implemented question Further information is requested

Comments

@kensei-te
Copy link
Collaborator

Right now, I think we flag only when it is curated. For curator, it might be convenient if we could flag even for correct one as "validated", so that curator can know that he/she checked the item. How do you think?

p.s. ID for each item also helps as I requested in older issue.

@lfoppiano
Copy link
Owner

mmm, so you want to have a 2 step correction?

input -> corrected -> validated

I did not implement it because I was not sure whether people were going to correct the data twice..

What do you think?

@kensei-te
Copy link
Collaborator Author

mmm, so you want to have a 2 step correction?

input -> corrected -> validated

I did not implement it because I was not sure whether people were going to correct the data twice..

What do you think?

Sorry for confusing you. Maybe the word is not appropriate. "checked". Even if it is correct, I want to have an indicator that I checked if this is correct, so that I would not check the same entry twice. You know, it is quite often that curation job can remain unfinished, interrupted by other jobs. Then it would be difficult to distinguish which one is already checked.

@lfoppiano
Copy link
Owner

mmm, we need to have some more thinking here... I come back to you

@lfoppiano lfoppiano added frontend backend difficult question Further information is requested labels Apr 25, 2022
@lfoppiano
Copy link
Owner

lfoppiano commented Apr 26, 2022

The database will be changed so that records that are extracted are marked as "automatic+new".

In the interface there will be

  • "flag as correct" or
  • "flag as incorrect"
    (anything but a dropdown - note for @t29mato)

And from that point you can mark the record as valid or invalid.

Should we allow editing also when the record is flagged as correct?

@lfoppiano lfoppiano added this to the 0.5 milestone Apr 26, 2022
@kensei-te
Copy link
Collaborator Author

kensei-te commented Apr 26, 2022

The database will be changed so that records that are extracted are marked as "automatic+new".

In the interface there will be

  • "flag as correct" or
  • "flag as incorrect"
    (anything but a dropdown - note for @t29mato)

And from that point you can mark the record as valid or invalid.

OK, It will satisfy my request. Thanks!

Should we allow editing also when the record is flagged as correct?

Yes, please. We may flag "correct" for incorrect one by mistake.

@lfoppiano
Copy link
Owner

See updated diagram: #14 (comment)

@lfoppiano lfoppiano modified the milestones: 0.5, 0.4 Apr 28, 2022
@lfoppiano lfoppiano self-assigned this Oct 14, 2022
@lfoppiano lfoppiano added breaking change When the change might break the compatibility change in data db The issue requires a change in the data stored in db labels Oct 14, 2022
@lfoppiano
Copy link
Owner

lfoppiano commented Oct 14, 2022

List of tasks:

  • add /validate
  • remove /unflag and rename to /reset
  • update the script for computing the tabular information to set status=new for each new record
  • avoid flag/validate records that are obsolete, removed or empty
  • change edited record to "curated"
  • change validated record to "validated"
  • when calling "reset" the backend must revert to "curated" if previous_id exists (edited record) or "new" if the record was not edited
  • change the flag/unflag column using a radio button
  • reword the column for flag/validate/reset

@lfoppiano
Copy link
Owner

lfoppiano commented Oct 14, 2022

Query to update the database:

db.tabular.updateMany({status:'valid', type:'automatic'},{$set: {status:"new"}})
db.tabular.updateMany({status:'valid', type:'manual'},{$set: {status:"curated"}})

The updated API is:

  • /record/<id>/status to get the status flag of the record (type: manual/automatic, status: new,curated,validated,obsolete,invalid
  • /record/<id>/mark_validated to validate a record as correct and will result in (type: manual, status: valid)
  • /record/<id>/mark_incorrect to flag the record as incorrect and will result in (type: manual, status: invalid)
  • /record/<id>/reset to reset the record to the initaial state and will result in (type: automatic, status: new)

@lfoppiano
Copy link
Owner

After discussion here the latest flow. We rename "valid" to "curated" and we add an additional status "validated".

User can "reset" a "validated" record either to "new" or "curated", depending on the previous status.

record-correction

t29mato added a commit that referenced this issue Oct 21, 2022
…ctions (validate record, invalidate record, reset record) #67, #81
lfoppiano added a commit that referenced this issue Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend breaking change When the change might break the compatibility change in data db The issue requires a change in the data stored in db difficult frontend implemented question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants