Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Refont domain registration step 2 #993

Merged
merged 7 commits into from
Jan 25, 2025
Merged

fix: Refont domain registration step 2 #993

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3558c0b
fix: Refont domain registration step 2
Verifieddanny Jan 25, 2025
6417461
fix:remove duplicate csss property
Verifieddanny Jan 25, 2025
f7b1eaa
Fix: added required changes
Verifieddanny Jan 25, 2025
35085da
fix: update grid layout for nftSection and remove redundant property …
Verifieddanny Jan 25, 2025
89765ad
package-lock.json removed
Verifieddanny Jan 25, 2025
4eaa566
fix: removed "Your Nft"
Verifieddanny Jan 25, 2025
375e175
styling
Marchand-Nicolas Jan 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
133 changes: 66 additions & 67 deletions components/identities/pfpGallery.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,67 +1,66 @@
import React, { FunctionComponent, useState } from "react";
import styles from "../../styles/components/profilePic.module.css";
import NftCard from "../UI/nftCard";
import { debounce } from "../../utils/debounceService";
import WarningMessage from "../UI/warningMessage";
import PfpSkeleton from "./skeletons/pfpSkeleton";

type PfpGalleryProps = {
userNfts: StarkscanNftProps[];
isLoading?: boolean;
selectPfp: (nft: StarkscanNftProps) => void;
selectedPfp?: StarkscanNftProps | null;
};

const PfpGallery: FunctionComponent<PfpGalleryProps> = ({
userNfts,
isLoading = false,
selectPfp,
selectedPfp,
}) => {
const [isHovered, setIsHovered] = useState<string | null>(null);

const handleMouseEnter = debounce((id: string) => setIsHovered(id), 50);
const handleMouseLeave = debounce(() => setIsHovered(null), 50);

return (
<>
<div>
<p className={styles.subtitle}>Your NFTs</p>
<h2 className={styles.title}>Choose your NFT Profile picture</h2>
<div className={styles.nftSection}>
{isLoading ? (
<PfpSkeleton />
) : userNfts && userNfts.length > 0 ? (
userNfts.map((nft, index) => {
if (!nft.image_url) return null;
return (
<div
key={index}
onMouseEnter={() => handleMouseEnter(nft.token_id)}
onMouseLeave={handleMouseLeave}
>
<NftCard
image={nft.image_url as string}
name={nft.name as string}
selectPicture={() => selectPfp(nft)}
isHovered={isHovered === nft.token_id}
isSelected={selectedPfp?.token_id === nft.token_id}
/>
</div>
);
})
) : (
<div className="flex flex-col align-middle items-center">
<img src="/visuals/notFound.webp" alt="Not found" width={201} />
<WarningMessage>
You don&apos;t own any whitelisted NFTs yet
</WarningMessage>
</div>
)}
</div>
</div>
</>
);
};

export default PfpGallery;
import React, { FunctionComponent, useState } from "react";
import styles from "../../styles/components/profilePic.module.css";
import NftCard from "../UI/nftCard";
import { debounce } from "../../utils/debounceService";
import WarningMessage from "../UI/warningMessage";
import PfpSkeleton from "./skeletons/pfpSkeleton";

type PfpGalleryProps = {
userNfts: StarkscanNftProps[];
isLoading?: boolean;
selectPfp: (nft: StarkscanNftProps) => void;
selectedPfp?: StarkscanNftProps | null;
};

const PfpGallery: FunctionComponent<PfpGalleryProps> = ({
userNfts,
isLoading = false,
selectPfp,
selectedPfp,
}) => {
const [isHovered, setIsHovered] = useState<string | null>(null);

const handleMouseEnter = debounce((id: string) => setIsHovered(id), 50);
const handleMouseLeave = debounce(() => setIsHovered(null), 50);

return (
<>
<div>
<h2 className={styles.title}>Choose your NFT Profile picture</h2>
<div className={styles.nftSection}>
{isLoading ? (
<PfpSkeleton />
) : userNfts && userNfts.length > 0 ? (
userNfts.map((nft, index) => {
if (!nft.image_url) return null;
return (
<div
key={index}
onMouseEnter={() => handleMouseEnter(nft.token_id)}
Comment on lines +38 to +39
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Avoid using array index as key.

Using array index as key prop can lead to rendering issues if the array items are reordered, filtered, or modified. Consider using a more stable unique identifier like nft.token_id.

-  key={index}
+  key={nft.token_id}
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
key={index}
onMouseEnter={() => handleMouseEnter(nft.token_id)}
key={nft.token_id}
onMouseEnter={() => handleMouseEnter(nft.token_id)}

onMouseLeave={handleMouseLeave}
>
<NftCard
image={nft.image_url as string}
name={nft.name as string}
selectPicture={() => selectPfp(nft)}
isHovered={isHovered === nft.token_id}
isSelected={selectedPfp?.token_id === nft.token_id}
/>
</div>
);
})
) : (
<div className="flex flex-col align-middle items-center">
<img src="/visuals/notFound.webp" alt="Not found" width={201} />
<WarningMessage>
You don&apos;t own any whitelisted NFTs yet
</WarningMessage>
</div>
)}
</div>
</div>
</>
);
};

export default PfpGallery;
Loading