Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File extension of TypeScript launch script adjusted on Windows #2427

Merged
merged 4 commits into from
Oct 16, 2024

Conversation

petervdonovan
Copy link
Collaborator

@petervdonovan petervdonovan commented Oct 16, 2024

In this branch, the tests pass for me locally for TypeScript on Windows.

@petervdonovan
Copy link
Collaborator Author

It looks like only the Docker tests are failing now.

@lhstrh
Copy link
Member

lhstrh commented Oct 16, 2024

While not using the script may be a reasonable workaround, I think it makes the test less complete, and exposes us to problems like the failing Docker tests. @Depetrol had suggested that the issue was that the script didn't have a .ps1 extension, which seems simple to fix.

@Depetrol
Copy link
Collaborator

The reason why typescript tests are failing seems to be powershell in windows-latest image only being able to run scripts ending with .bat or .ps1 file extensions. An alternative fix(which I'll push to this branch) is to change the generated script in bin to end with .bat extension(to align with other targets) and modify the run command to run the .bat script.

@petervdonovan
Copy link
Collaborator Author

The reason why typescript tests are failing seems to be powershell in windows-latest image only being able to run scripts ending with .bat or .ps1 file extensions. An alternative fix(which I'll push to this branch) is to change the generated script in bin to end with .bat extension(to align with other targets) and modify the run command to run the .bat script.

Awesome, thanks Shulu!

@lhstrh lhstrh changed the title Do not try to run bash script on Windows during tests File extension of TypeScript launch script adjusted on Windows Oct 16, 2024
Co-authored-by: Marten Lohstroh <[email protected]>
@lhstrh lhstrh enabled auto-merge October 16, 2024 21:41
@lhstrh lhstrh added this pull request to the merge queue Oct 16, 2024
Merged via the queue into master with commit b76c063 Oct 16, 2024
24 checks passed
@lhstrh lhstrh deleted the fix-ts-windows2 branch October 16, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants