-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Patmos platform #2383
Conversation
@EhsanKhodadad, I enabled CI for you, but it looks like there are still some test failures. Please address those first. |
Thank you for enabling CI. The tester has not found a header file in the t-crest repository, because t-crest hasn't cloned on the tester's machine. |
Got it. Can you fix it in the workflow? |
153af0b
to
1144a7b
Compare
Sure |
Btw, I noticed tests in your fork were failing. Here's a fix for that: #2402 |
ca8131e
to
55e4323
Compare
I have two questions regarding this PR:
|
@lhstrh @erlingrj @lsk567 Could you answer these questions, please? Thanks. |
Check out your file CPatmosTests.java, here you explicitly run these tests with
You should not run any Patmos-specific tests in C/regular-tests. They should be excluded from there and only be built in there special target. Do a search for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This overall look good! Let me defer to @erlingrj for final approval.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but we should not update reactor-cpp submodule in this PR
@EhsanKhodadad, please make sure reactor-cpp points to dfdac2c. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, lets merge :)
Finally, very good! |
Patmos docs updated to reflect lf-lang/lingua-franca#2383
No description provided.