Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the PRET VM instructions in the C target. For portability, I argue that the right approach is to fix the data types, this is also what the JVM does. A JVM
long
is always 64 bit, regardless of platform.I found a very nice way of making the instruction format flexible using
union
in C. Now the C implementation has the following semantics for instruction operands.Each operand is either
See the companion PR in reactor-c here: lf-lang/reactor-c#277