-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scheduling enclaves in the C target #1872
Conversation
…ion between delay and forward body
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, this is a big PR. A real tour-de-force. I've made some suggestions and raised some questions, but I didn't review closely all the code.
core/src/main/java/org/lflang/generator/ReactionInstanceGraph.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/lflang/generator/c/CEnclaveGenerator.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/lflang/generator/c/CEnclaveGenerator.java
Outdated
Show resolved
Hide resolved
import org.lflang.generator.RuntimeRange; | ||
import org.lflang.generator.SendRange; | ||
|
||
public class CEnclaveGraph { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why doesn't this class use the existing graph classes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was not able to get what I want from the Directed Graph class as it is only able to represent Nodes of arbitrary types not Edges. For the Enclave graph it is important to annotate the edges with after-delays and connection type (physical or normal)
Thanks for feedback Edward. I will address this. The PR is still a draft and I think I should do a proper pass through it and fix documentation and etc before anyone looks at it seriously |
Co-authored-by: Edward A. Lee <[email protected]>
…ocal RTI header files.
@lhstrh and @edwardalee, I am tagging you for a review now. We still have a test failure on macOS with coordinated shutdown of enclaves which I will look at in ~10 days. I have made a pass over all the changes and tried to bring the docs up to date. I kept my custom graph implementation due to the need to annotate edges, not nodes as is done in the other graphs. I will be mostly offline the next 8 days. |
Fix expensive way of finding the parent enclave of a reactorInstance
Closing this as we are pursuing a different AST strategy. See #2104 |
This PR adds the first version of the implementation of scheduling enclaves in the C target. It is paired with this PR in reactor-c: lf-lang/reactor-c#242