Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scheduling enclaves in the C target #1872

Closed
wants to merge 69 commits into from
Closed

Scheduling enclaves in the C target #1872

wants to merge 69 commits into from

Conversation

erlingrj
Copy link
Collaborator

@erlingrj erlingrj commented Jun 28, 2023

This PR adds the first version of the implementation of scheduling enclaves in the C target. It is paired with this PR in reactor-c: lf-lang/reactor-c#242

@erlingrj erlingrj marked this pull request as draft June 28, 2023 16:49
Copy link
Collaborator

@edwardalee edwardalee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this is a big PR. A real tour-de-force. I've made some suggestions and raised some questions, but I didn't review closely all the code.

import org.lflang.generator.RuntimeRange;
import org.lflang.generator.SendRange;

public class CEnclaveGraph {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why doesn't this class use the existing graph classes?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was not able to get what I want from the Directed Graph class as it is only able to represent Nodes of arbitrary types not Edges. For the Enclave graph it is important to annotate the edges with after-delays and connection type (physical or normal)

@erlingrj
Copy link
Collaborator Author

Thanks for feedback Edward. I will address this. The PR is still a draft and I think I should do a proper pass through it and fix documentation and etc before anyone looks at it seriously

@erlingrj erlingrj requested review from edwardalee and lhstrh July 13, 2023 12:19
@erlingrj
Copy link
Collaborator Author

@lhstrh and @edwardalee, I am tagging you for a review now. We still have a test failure on macOS with coordinated shutdown of enclaves which I will look at in ~10 days. I have made a pass over all the changes and tried to bring the docs up to date. I kept my custom graph implementation due to the need to annotate edges, not nodes as is done in the other graphs. I will be mostly offline the next 8 days.

@erlingrj
Copy link
Collaborator Author

Closing this as we are pursuing a different AST strategy. See #2104

@erlingrj erlingrj closed this Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants