Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to Rust setup in CI #1329

Merged
merged 2 commits into from
Aug 22, 2022
Merged

Fixes to Rust setup in CI #1329

merged 2 commits into from
Aug 22, 2022

Conversation

cmnrd
Copy link
Collaborator

@cmnrd cmnrd commented Aug 22, 2022

This PR solves two issues:

  1. It adds a workaround for a problem in the action that we are using for setting up rust (https://github.com/ATiltedTree/setup-rust/issues/157). This problem currently causes test failures on master (https://github.com/lf-lang/lingua-franca/runs/7951505913?check_suite_focus=true). It is caused by some internal bug of rustup and can be worked around by deleting its cache (Corrupt /missing manifests lead to installation conflicts rust-lang/rustup#2417). This change implements this such that if setting up rusts fails, we manually delete the cache and then try again.
  2. Since Inclusion of reactor-rs as a submodule #1296 the rust runtime is included as a submodule. However, we forgot to update the CI setup for rust accordingly. This PR fixes the setup and correctly checks out the specified ref of the submodule

@cmnrd cmnrd marked this pull request as ready for review August 22, 2022 12:47
@cmnrd cmnrd merged commit 387a996 into master Aug 22, 2022
@cmnrd cmnrd deleted the ci-rust-fix branch August 22, 2022 12:56
@cmnrd cmnrd mentioned this pull request Sep 7, 2022
2 tasks
@lhstrh lhstrh changed the title Fix rust setup in CI Fixes to Rust setup in CI Jan 26, 2023
@lhstrh lhstrh added the ci Continuous integration label Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants