Fix dhcpcd arguments for static IP config #4659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit bcb650f (pillar: enhance NTP server handling) introduced a bug in DhcpcdConfigurator (EVE version 14.0.0), where certain arguments for dhcpcd may be unintentionally omitted in static IP configurations. Specifically, the configuration file option (-f), background execution (-b), and infinite timeout (-t 0) may be missing. As a result, if dhcpcd starts while the network cable is unplugged, it will time out after 30 seconds and exit. Consequently, even after the cable is reconnected, dhcpcd will no longer be running to apply the static IP. Signed-off-by: Milan Lenco <[email protected]>
milan-zededa
requested review from
eriknordmark,
uncleDecart and
christoph-zededa
christoph-zededa
approved these changes
Mar 4, 2025
uncleDecart
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit bcb650f (
pillar: enhance NTP server handling) introduced a bug inDhcpcdConfigurator(EVE version14.0.0), where certain arguments fordhcpcdmay be unintentionally omitted in static IP configurations.Specifically, the configuration file option (
-f), background execution (-b), and infinite timeout (-t 0) may be missing. As a result, ifdhcpcdstarts while the network cable is unplugged, it will timeout after 30 seconds (default timeout) and exit. Consequently, even after the cable is reconnected,dhcpcdwill no longer be running to apply the static IP.