Ecc errors new info type #89
Conversation
jsfakian
commented
Feb 20, 2025
jsfakian
commented
- Added new types of ZInfoMsg protobuf messages for reporting the status of ECC memory
jsfakian
force-pushed
the
ECC-errors-new-info-type
branch
from
3d6992b to
eadcd38
Compare
jsfakian
force-pushed
the
ECC-errors-new-info-type
branch
2 times, most recently
from
5dc06dd to
9489472
Compare
jsfakian
force-pushed
the
ECC-errors-new-info-type
branch
2 times, most recently
from
09b1142 to
d022e7e
Compare
|
I named the new metrics healthchecks because they make more sense to me. @eriknordmark, Should I address the issues with Apache Yetus or ignore them? Are you okay with the new message type? |
jsfakian
force-pushed
the
ECC-errors-new-info-type
branch
from
d022e7e to
6adf0a9
Compare
| // The message is secured within a TLS session, which is bound to the device | ||
| // certificate to ensure integrity and authenticity. |
There was a problem hiding this comment.
Shouldn't we be using AuthContainer here where the AuthContainer is signed using the device identity?
(We don't seem to be using that for the Info and Metrics messages but it would make sense to introduce it for new messages like this one.)
There was a problem hiding this comment.
It is a good idea to use the AuthContainer. However, I need some help implementing it. Can you give me some pointers? I saw how we do it for CompoundEdgeDevConfig in proto/config/compound_devconfig.proto, but I am unsure how to do it in our case.
There was a problem hiding this comment.
Sure I can provide pointers. I don't know if we have sending code in EVE-OS or only have the receiving code.
For now it makes sense to update the comments in this API PR.
|
|
||
| import "google/protobuf/timestamp.proto"; | ||
|
|
||
| package org.lfedge.eve.healthchecks; |
There was a problem hiding this comment.
FWIW you can ignore the buflint complaints for this line.
jsfakian
force-pushed
the
ECC-errors-new-info-type
branch
3 times, most recently
from
dcc0f47 to
a91bc64
Compare
…are. - Added a new type of protobuf messages, ZHardwareHealth to report issues concerning the sensitive hardware components of a device - Currently, we introduce a report for ECC error messages Signed-off-by: Ioannis Sfakianakis <[email protected]>
Signed-off-by: Ioannis Sfakianakis <[email protected]>
jsfakian
force-pushed
the
ECC-errors-new-info-type
branch
from
a91bc64 to
b54eb2e
Compare
