Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix kafka sinke metrics #3549

Merged
merged 1 commit into from
Feb 17, 2025
Merged

Conversation

Yisaer
Copy link
Collaborator

@Yisaer Yisaer commented Feb 17, 2025

No description provided.

Signed-off-by: Song Gao <[email protected]>
@Yisaer Yisaer requested a review from ngjaying February 17, 2025 05:11
Copy link

codecov bot commented Feb 17, 2025

Codecov Report

Attention: Patch coverage is 22.22222% with 7 lines in your changes missing coverage. Please review.

Project coverage is 71.12%. Comparing base (4cb8280) to head (d778647).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
extensions/impl/kafka/sink.go 22.22% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3549      +/-   ##
==========================================
+ Coverage   71.08%   71.12%   +0.04%     
==========================================
  Files         417      417              
  Lines       48138    48120      -18     
==========================================
+ Hits        34217    34222       +5     
+ Misses      11242    11221      -21     
+ Partials     2679     2677       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ngjaying ngjaying merged commit 2366bd5 into lf-edge:master Feb 17, 2025
57 of 58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants