Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(kafka): change to byte collector #3545

Merged
merged 1 commit into from
Feb 14, 2025
Merged

Conversation

ngjaying
Copy link
Collaborator

  • Move batch implementation into Kafka sink itself
  • Support template in batch
  • Support different encode format besides json

@ngjaying ngjaying force-pushed the kafka branch 2 times, most recently from 7969216 to 02d0872 Compare February 14, 2025 03:53
- Move batch implementation into Kafka sink itself
- Support template in batch
- Support different encode format besides json

Signed-off-by: Jiyong Huang <[email protected]>
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

Attention: Patch coverage is 38.54167% with 59 lines in your changes missing coverage. Please review.

Project coverage is 71.11%. Comparing base (3e10b7f) to head (76e6cf2).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
extensions/impl/kafka/sink.go 32.91% 52 Missing and 1 partial ⚠️
internal/testx/testUtil.go 55.56% 4 Missing ⚠️
internal/topo/planner/planner_sink.go 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3545      +/-   ##
==========================================
- Coverage   71.19%   71.11%   -0.08%     
==========================================
  Files         417      417              
  Lines       48088    48138      +50     
==========================================
- Hits        34236    34232       -4     
- Misses      11182    11230      +48     
- Partials     2670     2676       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ngjaying ngjaying marked this pull request as ready for review February 14, 2025 06:33
@ngjaying ngjaying requested a review from Yisaer February 14, 2025 06:33
@Yisaer Yisaer merged commit 4cb8280 into lf-edge:master Feb 14, 2025
57 of 58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants