Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(state): untriggerd rule always cancel #3435

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

ngjaying
Copy link
Collaborator

validate may plan topo but not run if rule is not triggered. This will lead to buffer full if the source is a shared source.

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.14%. Comparing base (85af151) to head (67753ed).
Report is 1 commits behind head on master-2.0.

Additional details and impacted files
@@              Coverage Diff               @@
##           master-2.0    #3435      +/-   ##
==============================================
- Coverage       71.25%   71.14%   -0.11%     
==============================================
  Files             400      400              
  Lines           45342    45343       +1     
==============================================
- Hits            32306    32255      -51     
- Misses          10511    10549      +38     
- Partials         2525     2539      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ngjaying ngjaying marked this pull request as ready for review December 10, 2024 06:47
@ngjaying ngjaying requested a review from Yisaer December 10, 2024 06:47
validate may plan topo but not run if rule is not triggered. This will lead to buffer full if the source is a shared source.

Signed-off-by: Jiyong Huang <[email protected]>
@ngjaying ngjaying merged commit 444c9af into lf-edge:master-2.0 Dec 10, 2024
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants