Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: redisPubSub ping #2739

Merged
merged 1 commit into from
Mar 27, 2024
Merged

fix: redisPubSub ping #2739

merged 1 commit into from
Mar 27, 2024

Conversation

retoool
Copy link
Contributor

@retoool retoool commented Mar 26, 2024

No description provided.

Signed-off-by: XinTong Zhou <[email protected]>
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 73.68421% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 63.53%. Comparing base (2e50db1) to head (0d048ef).

Files Patch % Lines
internal/io/redis/pubsub/redisPub.go 71.43% 3 Missing and 1 partial ⚠️
internal/io/redis/pubsub/redisSub.go 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2739      +/-   ##
==========================================
- Coverage   63.54%   63.53%   -0.01%     
==========================================
  Files         339      339              
  Lines       38974    38984      +10     
==========================================
+ Hits        24763    24765       +2     
- Misses      12047    12052       +5     
- Partials     2164     2167       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ngjaying ngjaying requested a review from Yisaer March 27, 2024 01:59
@ngjaying ngjaying merged commit 3d78e32 into lf-edge:master Mar 27, 2024
58 checks passed
ngjaying pushed a commit to ngjaying/kuiper that referenced this pull request Mar 29, 2024
ngjaying pushed a commit to ngjaying/kuiper that referenced this pull request Mar 29, 2024
ngjaying pushed a commit to ngjaying/kuiper that referenced this pull request Mar 29, 2024
ngjaying pushed a commit that referenced this pull request Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants