Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module): modularize converter #2728

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

ngjaying
Copy link
Collaborator

No description provided.

@ngjaying ngjaying force-pushed the modularizeConverter branch from 44ee80f to c10732c Compare March 22, 2024 07:47
@ngjaying ngjaying force-pushed the modularizeConverter branch from c10732c to 538862b Compare March 22, 2024 08:00
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

Attention: Patch coverage is 79.16667% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 63.52%. Comparing base (264bfef) to head (538862b).

Files Patch % Lines
internal/converter/converter.go 81.82% 1 Missing and 1 partial ⚠️
internal/converter/ext_mock.go 0.00% 1 Missing and 1 partial ⚠️
internal/xsql/parser.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2728      +/-   ##
==========================================
- Coverage   63.54%   63.52%   -0.02%     
==========================================
  Files         339      339              
  Lines       38945    38937       -8     
==========================================
- Hits        24744    24732      -12     
- Misses      12036    12039       +3     
- Partials     2165     2166       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ngjaying ngjaying marked this pull request as ready for review March 25, 2024 02:17
@ngjaying ngjaying requested a review from Yisaer March 25, 2024 02:17
@ngjaying ngjaying merged commit e9166e5 into lf-edge:master Mar 25, 2024
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants