Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix influx sink configure #2670

Merged
merged 2 commits into from
Mar 5, 2024
Merged

fix: fix influx sink configure #2670

merged 2 commits into from
Mar 5, 2024

Conversation

Yisaer
Copy link
Collaborator

@Yisaer Yisaer commented Mar 5, 2024

No description provided.

Signed-off-by: yisaer <[email protected]>
@Yisaer Yisaer requested a review from ngjaying March 5, 2024 02:21
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.00%. Comparing base (a2f5d88) to head (9403af2).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2670      +/-   ##
==========================================
- Coverage   64.03%   64.00%   -0.03%     
==========================================
  Files         329      329              
  Lines       38418    38418              
==========================================
- Hits        24599    24588      -11     
- Misses      11654    11662       +8     
- Partials     2165     2168       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ngjaying ngjaying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can add a test in the configure test.

Signed-off-by: yisaer <[email protected]>
@Yisaer Yisaer requested a review from ngjaying March 5, 2024 08:14
@ngjaying ngjaying merged commit a6e669b into lf-edge:master Mar 5, 2024
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants