Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(node): split shared connection as a node #2613

Merged
merged 2 commits into from
Feb 6, 2024

Conversation

ngjaying
Copy link
Collaborator

@ngjaying ngjaying commented Feb 6, 2024

No description provided.

@ngjaying ngjaying force-pushed the sharedConn branch 2 times, most recently from 430c861 to 7e49c4a Compare February 6, 2024 03:54
Copy link

codecov bot commented Feb 6, 2024

Codecov Report

Attention: 124 lines in your changes are missing coverage. Please review.

Comparison is base (f502d0a) 63.94% compared to head (cf13173) 63.98%.
Report is 6 commits behind head on master.

Files Patch % Lines
internal/io/mqtt/connection.go 74.17% 23 Missing and 8 partials ⚠️
internal/meta/yamlConfigMeta.go 61.43% 25 Missing and 2 partials ⚠️
internal/processor/stream.go 77.14% 11 Missing and 5 partials ⚠️
internal/io/mqtt/mqtt_source_connector.go 65.12% 14 Missing and 1 partial ⚠️
internal/topo/planner/planner.go 83.87% 9 Missing and 1 partial ⚠️
internal/io/mqtt/connection_pool.go 80.65% 4 Missing and 2 partials ⚠️
internal/topo/subtopo.go 88.68% 4 Missing and 2 partials ⚠️
...rnal/converter/protobuf/fieldConverterSingleton.go 72.73% 2 Missing and 1 partial ⚠️
internal/server/rule_manager.go 0.00% 3 Missing ⚠️
internal/topo/node/source_connector_node.go 25.00% 2 Missing and 1 partial ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2613      +/-   ##
==========================================
+ Coverage   63.94%   63.98%   +0.04%     
==========================================
  Files         330      330              
  Lines       38188    38325     +137     
==========================================
+ Hits        24416    24520     +104     
- Misses      11592    11638      +46     
+ Partials     2180     2167      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ngjaying ngjaying marked this pull request as ready for review February 6, 2024 06:39
@ngjaying ngjaying requested a review from Yisaer February 6, 2024 06:39
@ngjaying ngjaying merged commit b77e40b into lf-edge:master Feb 6, 2024
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants