Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix protobuf oneof decode #2610

Merged
merged 3 commits into from
Feb 5, 2024
Merged

fix: fix protobuf oneof decode #2610

merged 3 commits into from
Feb 5, 2024

Conversation

Yisaer
Copy link
Collaborator

@Yisaer Yisaer commented Feb 5, 2024

No description provided.

Signed-off-by: Song Gao <[email protected]>
Signed-off-by: Song Gao <[email protected]>
Copy link

codecov bot commented Feb 5, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (f502d0a) 63.94% compared to head (f75bc19) 63.93%.
Report is 2 commits behind head on master.

❗ Current head f75bc19 differs from pull request most recent head 674597a. Consider uploading reports for the commit 674597a to get more accurate results

Files Patch % Lines
...rnal/converter/protobuf/fieldConverterSingleton.go 72.73% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2610      +/-   ##
==========================================
- Coverage   63.94%   63.93%   -0.00%     
==========================================
  Files         330      330              
  Lines       38188    38197       +9     
==========================================
+ Hits        24416    24421       +5     
- Misses      11592    11594       +2     
- Partials     2180     2182       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Yisaer Yisaer requested a review from ngjaying February 5, 2024 05:44
@Yisaer Yisaer marked this pull request as ready for review February 5, 2024 05:44
Signed-off-by: Song Gao <[email protected]>
@Yisaer Yisaer requested a review from ngjaying February 5, 2024 08:06
@ngjaying ngjaying merged commit 5b89c47 into lf-edge:master Feb 5, 2024
56 checks passed
ngjaying pushed a commit to ngjaying/kuiper that referenced this pull request Feb 6, 2024
ngjaying pushed a commit to ngjaying/kuiper that referenced this pull request Feb 6, 2024
ngjaying pushed a commit to ngjaying/kuiper that referenced this pull request Feb 6, 2024
ngjaying pushed a commit that referenced this pull request Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants