Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(topo): subtopo runtime fix #2609

Merged
merged 2 commits into from
Feb 5, 2024
Merged

fix(topo): subtopo runtime fix #2609

merged 2 commits into from
Feb 5, 2024

Conversation

ngjaying
Copy link
Collaborator

@ngjaying ngjaying commented Feb 4, 2024

No description provided.

Make sure only one instance is running.

Signed-off-by: Jiyong Huang <[email protected]>
Copy link

codecov bot commented Feb 4, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (f502d0a) 63.94% compared to head (e0de2ab) 63.92%.

Files Patch % Lines
internal/topo/subtopo.go 88.24% 4 Missing and 2 partials ⚠️
internal/topo/topo.go 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2609      +/-   ##
==========================================
- Coverage   63.94%   63.92%   -0.01%     
==========================================
  Files         330      330              
  Lines       38188    38219      +31     
==========================================
+ Hits        24416    24431      +15     
- Misses      11592    11604      +12     
- Partials     2180     2184       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ngjaying ngjaying marked this pull request as ready for review February 4, 2024 09:49
@ngjaying ngjaying requested a review from Yisaer February 4, 2024 09:50
@ngjaying ngjaying merged commit b991aaf into lf-edge:master Feb 5, 2024
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants