Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support expr validate #2608

Merged
merged 3 commits into from
Feb 5, 2024
Merged

Conversation

Yisaer
Copy link
Collaborator

@Yisaer Yisaer commented Feb 4, 2024

No description provided.

Signed-off-by: Song Gao <[email protected]>
@Yisaer Yisaer force-pushed the support_plan_validate branch from d664429 to f9cc41c Compare February 4, 2024 07:15
Copy link

codecov bot commented Feb 4, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (f502d0a) 63.94% compared to head (c60140d) 63.94%.

Files Patch % Lines
internal/topo/planner/planner.go 78.57% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2608      +/-   ##
==========================================
+ Coverage   63.94%   63.94%   +0.01%     
==========================================
  Files         330      330              
  Lines       38188    38213      +25     
==========================================
+ Hits        24416    24434      +18     
- Misses      11592    11597       +5     
- Partials     2180     2182       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Song Gao <[email protected]>
@Yisaer Yisaer marked this pull request as ready for review February 5, 2024 02:30
@Yisaer Yisaer changed the title feat: support plan validate feat: support expr validate Feb 5, 2024
Signed-off-by: Song Gao <[email protected]>
@ngjaying ngjaying merged commit ec5dc23 into lf-edge:master Feb 5, 2024
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants