Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add error code #2598

Merged
merged 7 commits into from
Feb 1, 2024
Merged

feat: add error code #2598

merged 7 commits into from
Feb 1, 2024

Conversation

Yisaer
Copy link
Collaborator

@Yisaer Yisaer commented Jan 31, 2024

No description provided.

Signed-off-by: Song Gao <[email protected]>
Signed-off-by: Song Gao <[email protected]>
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Comparison is base (cea5c54) 63.80% compared to head (3cafbd2) 63.85%.

Files Patch % Lines
internal/topo/rule/ruleState.go 48.84% 16 Missing and 6 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2598      +/-   ##
==========================================
+ Coverage   63.80%   63.85%   +0.05%     
==========================================
  Files         329      329              
  Lines       38077    38140      +63     
==========================================
+ Hits        24294    24352      +58     
+ Misses      11615    11609       -6     
- Partials     2168     2179      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Song Gao <[email protected]>
Signed-off-by: Song Gao <[email protected]>
Signed-off-by: Song Gao <[email protected]>
@Yisaer Yisaer requested a review from ngjaying February 1, 2024 01:02
@Yisaer Yisaer marked this pull request as ready for review February 1, 2024 01:02
Copy link
Collaborator

@ngjaying ngjaying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a typo problem

@Yisaer Yisaer requested a review from ngjaying February 1, 2024 07:26
@ngjaying ngjaying merged commit 2d0ddb8 into lf-edge:master Feb 1, 2024
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants