Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(node): split source connector and decoder #2583

Merged
merged 7 commits into from
Jan 30, 2024

Conversation

ngjaying
Copy link
Collaborator

No description provided.

@ngjaying ngjaying force-pushed the split2 branch 7 times, most recently from c71cb7f to 1839c3a Compare January 25, 2024 02:15
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 89 lines in your changes are missing coverage. Please review.

Comparison is base (a687968) 63.07% compared to head (763f447) 63.75%.
Report is 1 commits behind head on master.

Files Patch % Lines
internal/topo/planner/planner.go 65.85% 21 Missing and 7 partials ⚠️
internal/io/mock/test_source_connector.go 78.72% 10 Missing ⚠️
internal/topo/planner/planner_graph.go 75.61% 9 Missing and 1 partial ⚠️
pkg/infra/saferun.go 23.08% 10 Missing ⚠️
internal/topo/node/decode_op.go 89.89% 7 Missing and 2 partials ⚠️
internal/topo/subtopo.go 88.57% 6 Missing and 2 partials ⚠️
internal/topo/topo.go 79.49% 8 Missing ⚠️
internal/io/mqtt/mqtt_source_connector.go 89.83% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2583      +/-   ##
==========================================
+ Coverage   63.07%   63.75%   +0.68%     
==========================================
  Files         320      326       +6     
  Lines       37498    37973     +475     
==========================================
+ Hits        23651    24208     +557     
+ Misses      11708    11603     -105     
- Partials     2139     2162      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ngjaying ngjaying force-pushed the split2 branch 13 times, most recently from 16797a7 to b434f41 Compare January 26, 2024 12:12
@ngjaying ngjaying force-pushed the split2 branch 2 times, most recently from a72c7ae to b577d84 Compare January 26, 2024 13:24
Signed-off-by: Jiyong Huang <[email protected]>
Also add mutex for node outputs to allow dynamic change

Signed-off-by: Jiyong Huang <[email protected]>
@ngjaying ngjaying marked this pull request as ready for review January 28, 2024 04:06
@ngjaying ngjaying requested a review from yiqunc-emqx as a code owner January 28, 2024 04:06
@ngjaying ngjaying requested review from Yisaer and removed request for yiqunc-emqx January 28, 2024 04:06
@ngjaying ngjaying merged commit 588640c into lf-edge:master Jan 30, 2024
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants