Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add sniffio dependency for python plugins #2513

Merged
merged 3 commits into from
Dec 26, 2023

Conversation

Yisaer
Copy link
Collaborator

@Yisaer Yisaer commented Dec 26, 2023

Need to add this since pynng 0.7.4 version.

Signed-off-by: yisaer <[email protected]>
@Yisaer Yisaer requested a review from ngjaying December 26, 2023 07:33
Copy link

codecov bot commented Dec 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2f69979) 62.67% compared to head (855a227) 62.68%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2513      +/-   ##
==========================================
+ Coverage   62.67%   62.68%   +0.01%     
==========================================
  Files         308      308              
  Lines       36618    36618              
==========================================
+ Hits        22950    22953       +3     
+ Misses      11551    11548       -3     
  Partials     2117     2117              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ngjaying ngjaying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need doc update.

Signed-off-by: yisaer <[email protected]>
Signed-off-by: yisaer <[email protected]>
@Yisaer Yisaer requested a review from ngjaying December 26, 2023 08:29
@ngjaying ngjaying changed the title test: fix test chore: add sniffio dependency for python plugins Dec 26, 2023
@ngjaying ngjaying merged commit 3008fcf into lf-edge:master Dec 26, 2023
@Yisaer Yisaer deleted the fix_test_2 branch December 26, 2023 08:34
ngjaying pushed a commit that referenced this pull request Jan 4, 2024
ngjaying pushed a commit to ngjaying/kuiper that referenced this pull request Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants