Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support stop and cron timestamp api #2451

Merged
merged 2 commits into from
Dec 4, 2023

Conversation

Yisaer
Copy link
Collaborator

@Yisaer Yisaer commented Dec 1, 2023

1 . support timestamp for cronDatetimeRange
2. support stop api

Signed-off-by: yisaer <[email protected]>
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Attention: 51 lines in your changes are missing coverage. Please review.

Comparison is base (0737385) 62.61% compared to head (79d745c) 62.49%.

Files Patch % Lines
pkg/schedule/schedule.go 59.42% 22 Missing and 6 partials ⚠️
internal/server/server.go 5.88% 15 Missing and 1 partial ⚠️
internal/server/rest.go 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2451      +/-   ##
==========================================
- Coverage   62.61%   62.49%   -0.12%     
==========================================
  Files         307      307              
  Lines       36291    36348      +57     
==========================================
- Hits        22723    22715       -8     
- Misses      11467    11520      +53     
- Partials     2101     2113      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: yisaer <[email protected]>
@Yisaer Yisaer marked this pull request as ready for review December 1, 2023 06:33
@Yisaer Yisaer requested a review from ngjaying December 1, 2023 06:36
Copy link
Collaborator

@ngjaying ngjaying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the PR title and body to reflect all changes.

@Yisaer Yisaer changed the title feat: merge back features feat: support stop and cron timestamp api. Dec 4, 2023
@Yisaer Yisaer changed the title feat: support stop and cron timestamp api. feat: support stop and cron timestamp api Dec 4, 2023
@ngjaying ngjaying merged commit 37b0efc into lf-edge:master Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants