Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support schedule rule status timestamp #2449

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

Yisaer
Copy link
Collaborator

@Yisaer Yisaer commented Nov 30, 2023

No description provided.

Signed-off-by: yisaer <[email protected]>
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (5cb22b3) 62.28% compared to head (c4055ee) 62.29%.

Files Patch % Lines
internal/topo/rule/ruleState.go 56.25% 6 Missing and 1 partial ⚠️
internal/server/rule_manager.go 71.43% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2449   +/-   ##
=======================================
  Coverage   62.28%   62.29%           
=======================================
  Files         308      308           
  Lines       36394    36408   +14     
=======================================
+ Hits        22667    22677   +10     
+ Misses      11624    11623    -1     
- Partials     2103     2108    +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Yisaer Yisaer requested a review from ngjaying November 30, 2023 09:55
@Yisaer Yisaer marked this pull request as ready for review November 30, 2023 09:55
@ngjaying ngjaying merged commit 8483fb2 into lf-edge:master Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants