Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix syntax error in readme #2421

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Conversation

buildcomplete
Copy link
Contributor

Changed "written on" Go to "written in go"

Changed "written on" Go to "written in go"
@ngjaying
Copy link
Collaborator

Thanks @buildcomplete , please follow the Details link in DCO check to pass it firstly.

@ngjaying
Copy link
Collaborator

@buildcomplete Could you please take 5 minutes to sign the commit? Feel free to contact us if you have difficulties to do that. Thanks!

@buildcomplete
Copy link
Contributor Author

hi @ngjaying, I am not sure how to do it as I am not used to working with GIT, can I do it from github?

@ngjaying
Copy link
Collaborator

hi @ngjaying, I am not sure how to do it as I am not used to working with GIT, can I do it from github?

ah, unfortunately, github do not have the capability. Would you like to learn a little bit about git. https://github.com/lf-edge/ekuiper/pull/2421/checks?check_run_id=18754132161

@ngjaying ngjaying changed the title Update ekuiper.md docs: fix typo in readme Nov 30, 2023
@ngjaying ngjaying changed the title docs: fix typo in readme docs: fix syntax error in readme Nov 30, 2023
@ngjaying ngjaying merged commit b4bdf2a into lf-edge:master Nov 30, 2023
@buildcomplete
Copy link
Contributor Author

Thanks for completing the request, was having difficulty with coorporate network blocking git🪓 will remember the signoff for future.

@buildcomplete buildcomplete deleted the patch-1 branch November 30, 2023 11:21
@ngjaying
Copy link
Collaborator

ngjaying commented Dec 1, 2023

Thanks for completing the request, was having difficulty with coorporate network blocking git🪓 will remember the signoff for future.

It is not easy to set it up for new commers. You may want to share the tutorial if you can get it work. Appreciate your contribution to the project. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants