Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support websocket client reconnect #2409

Merged
merged 2 commits into from
Nov 13, 2023

Conversation

Yisaer
Copy link
Collaborator

@Yisaer Yisaer commented Nov 10, 2023

No description provided.

Signed-off-by: yisaer <[email protected]>
Signed-off-by: yisaer <[email protected]>
@Yisaer Yisaer changed the title feat: support websocket client connection reconnect feat: support websocket client reconnect Nov 10, 2023
@Yisaer Yisaer marked this pull request as ready for review November 10, 2023 07:06
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (5957047) 62.60% compared to head (ccdfd19) 62.56%.
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2409      +/-   ##
==========================================
- Coverage   62.60%   62.56%   -0.04%     
==========================================
  Files         302      302              
  Lines       35897    35954      +57     
==========================================
+ Hits        22472    22494      +22     
- Misses      11336    11369      +33     
- Partials     2089     2091       +2     
Files Coverage Δ
...nal/topo/connection/clients/websocket/websocket.go 44.19% <100.00%> (ø)
internal/topo/node/node.go 57.26% <0.00%> (ø)
pkg/infra/saferun.go 95.65% <88.89%> (-4.35%) ⬇️
internal/io/mqtt/mqtt_sink.go 26.51% <62.50%> (+3.84%) ⬆️
...o/connection/clients/websocket/websocket_client.go 64.80% <55.77%> (-7.29%) ⬇️

... and 14 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Yisaer Yisaer requested a review from ngjaying November 10, 2023 09:03
@ngjaying ngjaying merged commit c91d1be into lf-edge:master Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants