Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Concealing Passwords in Config Key Retrieval #2319

Merged
merged 2 commits into from
Oct 16, 2023

Conversation

Rui-Gan
Copy link
Collaborator

@Rui-Gan Rui-Gan commented Oct 15, 2023

No description provided.

Signed-off-by: Rui-Gan <[email protected]>
@codecov
Copy link

codecov bot commented Oct 15, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (b37cda6) 62.90% compared to head (9b1e2fe) 62.87%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2319      +/-   ##
==========================================
- Coverage   62.90%   62.87%   -0.04%     
==========================================
  Files         297      297              
  Lines       35433    35456      +23     
==========================================
+ Hits        22289    22290       +1     
- Misses      11084    11098      +14     
- Partials     2060     2068       +8     
Files Coverage Δ
internal/meta/yamlConfigMeta.go 39.40% <69.57%> (+2.29%) ⬆️

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Rui-Gan Rui-Gan marked this pull request as ready for review October 15, 2023 05:33
@Rui-Gan Rui-Gan marked this pull request as draft October 16, 2023 04:36
Signed-off-by: Rui-Gan <[email protected]>
@Rui-Gan Rui-Gan marked this pull request as ready for review October 16, 2023 06:25
@ngjaying ngjaying merged commit 3b53b22 into lf-edge:master Oct 16, 2023
ngjaying pushed a commit to ngjaying/kuiper that referenced this pull request Oct 18, 2023
ngjaying pushed a commit that referenced this pull request Oct 18, 2023
@Rui-Gan Rui-Gan deleted the config branch October 30, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants