Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(conf): syslog win syntax error #2294

Merged
merged 1 commit into from
Oct 8, 2023
Merged

Conversation

ngjaying
Copy link
Collaborator

@ngjaying ngjaying commented Oct 7, 2023

No description provided.

@codecov
Copy link

codecov bot commented Oct 7, 2023

Codecov Report

Attention: 54 lines in your changes are missing coverage. Please review.

Comparison is base (f5e0182) 62.79% compared to head (b98941a) 62.77%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2294      +/-   ##
==========================================
- Coverage   62.79%   62.77%   -0.01%     
==========================================
  Files         292      292              
  Lines       34995    35124     +129     
==========================================
+ Hits        21972    22048      +76     
- Misses      10990    11030      +40     
- Partials     2033     2046      +13     
Files Coverage Δ
internal/conf/logger/logger.go 76.00% <ø> (-0.92%) ⬇️
internal/io/http/client.go 84.30% <100.00%> (+0.11%) ⬆️
internal/pkg/cert/cert.go 71.05% <100.00%> (+18.88%) ⬆️
internal/topo/connection/clients/mqtt/mqtt.go 33.33% <100.00%> (+1.33%) ⬆️
internal/topo/planner/aggregatePlan.go 84.21% <100.00%> (-0.79%) ⬇️
internal/topo/planner/analyticFuncsPlan.go 90.32% <100.00%> (-0.30%) ⬇️
internal/topo/planner/dataSourcePlan.go 83.87% <100.00%> (-0.09%) ⬇️
internal/topo/planner/filterPlan.go 76.92% <100.00%> (-0.35%) ⬇️
internal/topo/planner/havingPlan.go 82.98% <100.00%> (-0.35%) ⬇️
internal/topo/planner/joinAlignPlan.go 77.78% <100.00%> (-0.79%) ⬇️
... and 13 more

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ngjaying ngjaying marked this pull request as ready for review October 8, 2023 01:03
@ngjaying ngjaying requested a review from Yisaer October 8, 2023 01:03
@ngjaying ngjaying merged commit 62691f7 into lf-edge:master Oct 8, 2023
ngjaying added a commit to ngjaying/kuiper that referenced this pull request Oct 9, 2023
ngjaying added a commit that referenced this pull request Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants