Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add android packaging #2268

Merged
merged 4 commits into from
Sep 20, 2023
Merged

Conversation

bing-zhub
Copy link
Contributor

@bing-zhub bing-zhub commented Sep 19, 2023

android_ekuiper

Many users want to deploy ekuiper on Android, in order to facilitate this part of the user, this PR compiles the ekuiper cross-platform to Android, and packages it to produce apk files.

Implementation:
Based on the cross-platform GUI toolkit fyne, using absolute path to read/write configuration files/logs, all configuration files and runtime files will be saved to /storage/emulated/0/ekuiper/ directory, if you need to modify the configuration information, please use the file manager to modify the corresponding file and then restart ekuiper.

Problems:
Can't get file storage permission automatically, need to enable it manually.

Closes #1123

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.04% 🎉

Comparison is base (438094d) 62.73% compared to head (210ba5b) 62.76%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2268      +/-   ##
==========================================
+ Coverage   62.73%   62.76%   +0.04%     
==========================================
  Files         289      291       +2     
  Lines       34664    34829     +165     
==========================================
+ Hits        21743    21860     +117     
- Misses      10912    10949      +37     
- Partials     2009     2020      +11     

see 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ngjaying ngjaying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!
What is the ttf file for? Is it required or can we remove it? Is it licensed? Thanks.

@bing-zhub
Copy link
Contributor Author

Thanks!

What is the ttf file for? Is it required or can we remove it?

When the UI needs to display non-ascii characters, it will be messed up without this font package (.tff), if the target users of this application are all English users, there is no problem to delete this font package and modify the corresponding theme file (theme.go).

Is it licensed?

This font is open source, its repository is at smiley-sans, it follows the SIL Open Font License 1.1. Users have the following permissions:

  • Private use
  • Commercial use
  • Modification
  • Distribution

@ngjaying
Copy link
Collaborator

Thanks!

What is the ttf file for? Is it required or can we remove it?

When the UI needs to display non-ascii characters, it will be messed up without this font package (.tff), if the target users of this application are all English users, there is no problem to delete this font package and modify the corresponding theme file (theme.go).

Is it licensed?

This font is open source, its repository is at smiley-sans, it follows the SIL Open Font License 1.1. Users have the following permissions:

  • Private use
  • Commercial use
  • Modification
  • Distribution

Looks like we need to delete the font as it does not allow commercial use which is conflict with Apache 2.0 license. Maybe we can add some instruction to the readme to guide users to add their own font.

@bing-zhub
Copy link
Contributor Author

Looks like we need to delete the font as it does not allow commercial use which is conflict with Apache 2.0 license. Maybe we can add some instruction to the readme to guide users to add their own font.

Sorry, I don't know much about these licenses. I'll follow up with a commit under this PR, remove the font package, and add documentation in README.md that supports non-ascii characters.

@ngjaying ngjaying requested a review from Rory-Z September 20, 2023 00:54
@ngjaying ngjaying merged commit 5158c4a into lf-edge:master Sep 20, 2023
@ngjaying
Copy link
Collaborator

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[OSPP]Support android
3 participants