Eden-SDN: add examples for application IP routing configurations #938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Milan Lenco <[email protected]>
Signed-off-by: Milan Lenco <[email protected]>
Signed-off-by: Milan Lenco <[email protected]>
milan-zededa
force-pushed
the
ni-routing
branch
from
d61da39 to
7726f4e
Compare
milan-zededa
changed the title
milan-zededa
force-pushed
the
ni-routing
branch
from
7726f4e to
a6ab306
Compare
giggsoff
reviewed
Jan 8, 2024
milan-zededa
force-pushed
the
ni-routing
branch
from
a6ab306 to
606588f
Compare
Signed-off-by: Milan Lenco <[email protected]>
milan-zededa
force-pushed
the
ni-routing
branch
from
606588f to
2bee2a2
Compare
|
@giggsoff @uncleDecart With the latest EVE version the example is now working as expected. I have updated the default EVE version used by eden and marked the PR as ready for review. |
giggsoff
approved these changes
Jan 18, 2024
uncleDecart
approved these changes
Jan 18, 2024
giggsoff
reviewed
Jan 19, 2024
| @@ -53,7 +53,7 @@ const ( | |||
| DefaultRegistryPort = 5050 | |||
|
|
|||
| //tags, versions, repos | |||
| DefaultEVETag = "10.11.0" // DefaultEVETag tag for EVE image | |||
| DefaultEVETag = "11.7.0" // DefaultEVETag tag for EVE image | |||
There was a problem hiding this comment.
FYI @milan-zededa seems moving to the new tag broke EdenGCP tests (3 attempts full failed vs previous full green).
There was a problem hiding this comment.
Can't be that we ran out of space, can it? https://github.com/lf-edge/eden/actions/runs/7568041549/job/20647150138#step:17:1641
There was a problem hiding this comment.
I will have a look at this early next week.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These examples cover propagation of IP routes from network instances to applications, implemented in EVE by this PR: lf-edge/eve#3690
Eventually, I would like to prepare an eden test (in Go), but for now we will have at least examples that can be run manually and used to test EVE.