eclient image improvements #937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giggsoff
reviewed
Dec 22, 2023
giggsoff
reviewed
Dec 22, 2023
Comment on lines
-9
to
+11
| google.golang.org/protobuf v1.28.1 h1:d0NfwRgPtno5B1Wa6L2DAG+KivqkdutMf1UhdNx175w= | ||
| google.golang.org/protobuf v1.28.1/go.mod h1:HV8QOd/L58Z+nl8r43ehVNZIU/HEI6OcFqwMG9pJV4I= | ||
| google.golang.org/protobuf v1.30.0 h1:kPPoIgf3TsEvrm0PFe15JQ+570QVxYzEvvHqChK+cng= | ||
| google.golang.org/protobuf v1.30.0/go.mod h1:HV8QOd/L58Z+nl8r43ehVNZIU/HEI6OcFqwMG9pJV4I= |
There was a problem hiding this comment.
Thank you for fixing this
giggsoff
reviewed
Dec 22, 2023
giggsoff
approved these changes
Dec 22, 2023
3 improvements: - enable IP forwarding so that eclient can be used in tests to simulate router application - run shell as the final foreground process. This enables to attach to the container using `eve attach-app-console` and enjoy interactive session - add tcpdump - it can be useful when debugging connectivity issues that prevent installing it in runtime Signed-off-by: Milan Lenco <[email protected]>
milan-zededa
force-pushed
the
eclient-improvements
branch
from
cb1efb0 to
2048a9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3 small improvements:
eve attach-app-consoleand enjoy interactive session