Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for log_test.txt #1046

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Fix for log_test.txt #1046

merged 1 commit into from
Dec 9, 2024

Conversation

europaul
Copy link
Contributor

@europaul europaul commented Dec 9, 2024

The original device config needs to be restored after the test is done.

The original device config needs to be restored after the test is done.

Signed-off-by: Paul Gaiduk <[email protected]>
@europaul europaul requested a review from uncleDecart as a code owner December 9, 2024 13:40
@europaul
Copy link
Contributor Author

europaul commented Dec 9, 2024

@uncleDecart could we please also create a new release once that's merged? sorry to ask so close after the last release 🙈

@uncleDecart
Copy link
Member

@europaul , should the tests here pass? I mean on EVE 13.7.0?

@europaul
Copy link
Contributor Author

europaul commented Dec 9, 2024

@europaul , should the tests here pass? I mean on EVE 13.7.0?

yes

@uncleDecart
Copy link
Member

How nice to see all the checks go green, huh? :D

Copy link
Member

@uncleDecart uncleDecart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uncleDecart uncleDecart merged commit 14567d9 into lf-edge:master Dec 9, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants