Skip to content
This repository has been archived by the owner on Aug 25, 2018. It is now read-only.

Add NANODBC_DEPRECATED macro #279

Merged
merged 1 commit into from
Jul 19, 2017
Merged

Add NANODBC_DEPRECATED macro #279

merged 1 commit into from
Jul 19, 2017

Conversation

mloskot
Copy link
Contributor

@mloskot mloskot commented Jul 19, 2017 •
edited
Loading

Mark and document async_completed as deprecated.

Closes #278

Use of deprecated function, eg. when building with VS2017, will issue warning like so

warning C4996: 'nanodbc::statement::async_complete': was declared deprecated
   note: see declaration of 'nanodbc::statement::async_complete'

@mloskot
Add NANODBC_DEPRECATED macro
3225913 
Mark and document async_completed as deprecated.

Closes #278
lexicalunit
lexicalunit approved these changes Jul 19, 2017
View reviewed changes
Copy link
Owner

@lexicalunit lexicalunit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mloskot
Copy link
Contributor Author

mloskot commented Jul 19, 2017

Merging despite OSX jobs failing on Travis CI.

@mloskot mloskot merged commit 8c3803b into lexicalunit:master Jul 19, 2017
@mloskot mloskot deleted the ml/deprecated branch July 19, 2017 19:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lexicalunit lexicalunit lexicalunit approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mloskot @lexicalunit