This repository has been archived by the owner on Aug 25, 2018. It is now read-only.
Add new method result::column_decimal_digits #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mloskot
changed the title
result::column_decimal_digits
|
Nice! 👍 |
|
As for the |
Add test for properties of result column descriptor. Add missing overloads to access column properties by column name. Re-arrange order of result and result_impl methods.
|
Cool, I have updated the commit with the missing overloads. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new method result::column_decimal_digits.
Add test for properties of result column descriptor.
Add missing overloads to access column properties by column name.
Re-arrange order of result and result_impl methods.
Question regarding the
result::column*methods:Some of them are overloaded for both, name and index, (e.g.
column_datatype) while some are not (e.g.column_size). Do we want to unify the interface, provide overloaded variants for all or remove the overloads for name?