Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Elixir 1.18 #849

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Support Elixir 1.18 #849

wants to merge 15 commits into from

Conversation

scohen
Copy link
Collaborator

@scohen scohen commented Dec 27, 2024

Support 1.18.

Test failures were due to old versions of beam files hanging around. This quiets warnings and all tests pass locally.

Fixes #846

@scohen scohen changed the title Support 1 18 Support Elixir 1.18 Dec 27, 2024
@Moosieus
Copy link
Collaborator

Moosieus commented Jan 2, 2025

I keep seeing errors pop up, seemingly due to some issue with elixir_sense. Logs here

@scohen
Copy link
Collaborator Author

scohen commented Jan 3, 2025

@Moosieus Updated elixir_sense. That should take care of the error you're seeing (I was told it's benign, but yes, it's gross).

@Moosieus
Copy link
Collaborator

Moosieus commented Jan 3, 2025

I was told it's benign, but yes, it's gross

That about sums up my experience. I've pulled the update, gonna work with it and see if anything else crops up.

@Moosieus
Copy link
Collaborator

Moosieus commented Jan 3, 2025

That seems to have done the trick

Copy link
Collaborator

@Moosieus Moosieus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Been using without issues, and the code looks good on review.

@trashhalo
Copy link

Not sure if this is an existing lexical thing and I just need to delete some file. but been getting issues with use statements where all of them are mad. including ones not from deps. like root app. use Standd, :controller.

Screenshot 2025-01-06 at 12 50 48 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Elixir 1.18 support
3 participants