Server bottlenecks #825
Merged
Server bottlenecks #825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scohen
force-pushed
the
cancel-timeouts
branch
from
9521cf7 to
f4221de
Compare
zachallaun
approved these changes
Sep 5, 2024
zachallaun
requested changes
Sep 5, 2024
When lots of things happen in lexical, it's necessary to kill some outstanding tasks that won't finish. When lots of things need to be killed (as in when a lot of files are changed), killing them can become a bottleneck. This is because we were using terminate_child, which makes a genserver call through the supervisor and waits for the pid to exit before it returns. This, in turn would cause the supervisor to back up and the task queue to die because of timeouts. Replacing this with `Process.exit` removes the bottleneck and doesn't seem to have any adverse effects.
scohen
force-pushed
the
cancel-timeouts
branch
from
f4221de to
62a1e18
Compare
zachallaun
approved these changes
Sep 5, 2024
Rather than piggyback on the build lock when getting project mix config, use a different lock type.
scohen
force-pushed
the
cancel-timeouts
branch
from
62a1e18 to
119a429
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed two bottlenecks in the server.
Task.Supervisor.terminate_childwas causing timeouts when bulk operations happen.