Convert all exceptions in config files into diagnostics

apps/remote_control/lib/lexical/remote_control/build/document/compilers/config.ex

@@ -6,6 +6,9 @@ defmodule Lexical.RemoteControl.Build.Document.Compilers.Config do
   alias Lexical.Document
   alias Lexical.Plugin.V1.Diagnostic
   alias Lexical.RemoteControl.Build
+  alias Lexical.RemoteControl.Build.Error.Location
+
+  @elixir_source "Elixir"
 
   @behaviour Build.Document.Compiler
   require Logger
@@ -49,7 +52,7 @@ defmodule Lexical.RemoteControl.Build.Document.Compilers.Config do
       {:ok, []}
     rescue
       e ->
-        {:error, [to_result(document, e)]}
+        {:error, [to_result(document, e, __STACKTRACE__)]}
     end
   end
 
@@ -73,33 +76,41 @@ defmodule Lexical.RemoteControl.Build.Document.Compilers.Config do
     end
   end
 
-  defp to_result(%Document{} = document, %CompileError{} = error) do
-    Diagnostic.Result.new(document.uri, error.line, Exception.message(error), :error, "Elixir")
+  defp to_result(document, error, stack \\ [])
+
+  defp to_result(%Document{} = document, %CompileError{} = error, _stack) do
+    Diagnostic.Result.new(
+      document.uri,
+      error.line,
+      Exception.message(error),
+      :error,
+      @elixir_source
+    )
   end
 
-  defp to_result(%Document{} = document, %error_type{} = error)
+  defp to_result(%Document{} = document, %error_type{} = error, _stack)
        when error_type in [SyntaxError, TokenMissingError] do
     Diagnostic.Result.new(
       document.uri,
       {error.line, error.column},
       Exception.message(error),
       :error,
-      "Elixir"
+      @elixir_source
     )
   end
 
-  defp to_result(%Document{} = document, %{
-         position: position,
-         message: message,
-         severity: severity
-       }) do
-    Diagnostic.Result.new(
-      document.path,
-      position,
-      message,
-      severity,
-      "Elixir"
-    )
+  defp to_result(
+         %Document{} = document,
+         %{position: position, message: message, severity: severity},
+         _stack
+       ) do
+    Diagnostic.Result.new(document.path, position, message, severity, @elixir_source)
+  end
+
+  defp to_result(%Document{} = document, %{__exception__: true} = exception, stack) do
+    message = Exception.message(exception)
+    position = Location.stack_to_position(stack)
+    Diagnostic.Result.new(document.path, position, message, :error, @elixir_source)
   end
 
   defp reject_logged_messages(results) do

apps/remote_control/lib/lexical/remote_control/build/error.ex

@@ -146,7 +146,7 @@ defmodule Lexical.RemoteControl.Build.Error do
         mfa = {module, function, arity}
         mfa_to_position(mfa, quoted_ast)
       else
-        stack_to_position(stack)
+        Location.stack_to_position(stack)
       end
 
     Result.new(source.uri, position, message, :error, @elixir_source)
@@ -182,7 +182,7 @@ defmodule Lexical.RemoteControl.Build.Error do
       if pipe_or_struct? or expanding? do
         Location.context_to_position(context)
       else
-        stack_to_position(stack)
+        Location.stack_to_position(stack)
       end
 
     Result.new(source.uri, position, message, :error, @elixir_source)
@@ -195,7 +195,7 @@ defmodule Lexical.RemoteControl.Build.Error do
              ExUnit.DuplicateDescribeError
            ] do
     message = Exception.message(exception)
-    position = stack_to_position(stack)
+    position = Location.stack_to_position(stack)
     Result.new(source.uri, position, message, :error, @elixir_source)
   end
 
@@ -281,20 +281,6 @@ defmodule Lexical.RemoteControl.Build.Error do
     end
   end
 
-  defp stack_to_position([{_, target, _, _} | rest])
-       when target not in [:__FILE__, :__MODULE__] do
-    stack_to_position(rest)
-  end
-
-  defp stack_to_position([{_, target, _, context} | _rest])
-       when target in [:__FILE__, :__MODULE__] do
-    Location.context_to_position(context)
-  end
-
-  defp stack_to_position([]) do
-    nil
-  end
-
   defp do_message_to_diagnostic(_, "") do
     nil
   end

apps/remote_control/lib/lexical/remote_control/build/error/location.ex

@@ -6,6 +6,20 @@ defmodule Lexical.RemoteControl.Build.Error.Location do
 
   require Logger
 
+  def stack_to_position([{_, target, _, _} | rest])
+      when target not in [:__FILE__, :__MODULE__] do
+    stack_to_position(rest)
+  end
+
+  def stack_to_position([{_, target, _, context} | _rest])
+      when target in [:__FILE__, :__MODULE__] do
+    context_to_position(context)
+  end
+
+  def stack_to_position([]) do
+    nil
+  end
+
   def context_to_position(context) do
     case {context[:line], context[:column]} do
       {nil, nil} ->

apps/remote_control/test/lexical/remote_control/build/document/compilers/config_test.exs

@@ -121,6 +121,25 @@ defmodule Lexical.RemoteControl.Build.Document.Compilers.ConfigTest do
       assert result.source == "Elixir"
     end
 
+    test "it produces diagnostics for arbitrary exceptions" do
+      assert {:error, [result]} =
+               ~q[
+                 import Config
+
+                 System.fetch_env!("_LEXICAL_NON_EXISTING_ENV_VAR_")
+               ]
+               |> document()
+               |> compile()
+
+      assert result.message =~ "could not fetch environment variable"
+      assert result.severity == :error
+      assert result.source == "Elixir"
+
+      if Features.with_diagnostics?() do
+        assert result.position == 3
+      end
+    end
+
     test "it produces no diagnostics on success" do
       assert {:ok, []} =
                ~q[

integration/boot/set_up_mise.sh

@@ -27,7 +27,6 @@ chmod +x ./mise
 eval "$(./mise activate bash)"
 
 export KERL_CONFIGURE_OPTIONS="--disable-debug --without-javac --without-termcap --without-wx"
-./mise plugin install -y erlang
 ./mise use --global "erlang@$ERLANG_VERSION"
 
 ./mise plugins install -y elixir