Properly handle expand_alias failures #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I initially assumed that the cases where `expand_alias` would fail
would be rare, so I did a hard match on `{:ok, alias}`. I was wrong,
the cases are much more common, and this is causing irritation for
people trying to use indexing. This change logs the cases where
expand_alias fails, and skips the entries, which should give better
developer experience and should also allow us to see what's causing
the failures.
scohen
force-pushed
the
handle-expand-alias-failures
branch
from
875e336 to
58012fc
Compare
|
@zachallaun @scottming I'm going to merge this, it's causing people issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I initially assumed that the cases where
expand_aliaswould fail would be rare, so I did a hard match on{:ok, alias}. I was wrong, the cases are much more common, and this is causing irritation for people trying to use indexing. This change logs the cases where expand_alias fails, and skips the entries, which should give better developer experience and should also allow us to see what's causing the failures.