Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix find-reference #493

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Fix find-reference #493

merged 1 commit into from
Nov 17, 2023

Conversation

scottming
Copy link
Collaborator

@scottming scottming commented Nov 17, 2023 •
edited
Loading

find-reference is broken on the main branch.

@zachallaun
Copy link
Collaborator

Whoops!

I'm surprised there isn't a test that caught this. Worth adding one?

@scottming
Copy link
Collaborator Author

I'm surprised there isn't a test that caught this. Worth adding one?

I think matching the Analysis struct here: https://github.com/lexical-lsp/lexical/pull/493/files#diff-cee6d5885f568da52d9067503a71fa4f9f0551e2fd1a49e9a8a0ebf40170e22dR52

Then it should be fine.

@zachallaun zachallaun merged commit c2113da into lexical-lsp:main Nov 17, 2023
7 checks passed
@scottming scottming deleted the fix-references branch December 20, 2023 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachallaun zachallaun zachallaun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scottming @zachallaun