Remove eager task types task<T> and shared_task<T>.

These types make it difficult to write exception-safe code
when compared with their lazy-task counterparts.

include/cppcoro/when_all.hpp

@@ -7,8 +7,6 @@
 
 #include <cppcoro/lazy_task.hpp>
 #include <cppcoro/shared_lazy_task.hpp>
-#include <cppcoro/shared_task.hpp>
-#include <cppcoro/task.hpp>
 #include <cppcoro/when_all_ready.hpp>
 
 #include <cppcoro/detail/unwrap_reference.hpp>
@@ -118,68 +116,6 @@ namespace cppcoro
 		co_return std::move(results);
 	}
 
-	//////////
-	// when_all() with vector of task
-
-	[[nodiscard]]
-	inline lazy_task<> when_all(std::vector<task<>> tasks)
-	{
-		// First wait until all tasks are ready using non-throwing when_ready().
-		for (auto& t : tasks)
-		{
-			co_await t.when_ready();
-		}
-
-		// Then await the value of the task so that any exceptions
-		// can be rethrown.
-		for (auto& t : tasks)
-		{
-			co_await std::move(t);
-		}
-	}
-
-	template<typename T>
-	[[nodiscard]]
-	lazy_task<std::vector<T>> when_all(std::vector<task<T>> tasks)
-	{
-		// First wait until all tasks are ready using non-throwing when_ready().
-		for (auto& t : tasks)
-		{
-			co_await t.when_ready();
-		}
-
-		std::vector<T> results;
-		results.reserve(tasks.size());
-
-		for (auto& t : tasks)
-		{
-			results.emplace_back(co_await std::move(t));
-		}
-
-		co_return std::move(results);
-	}
-
-	template<typename T>
-	[[nodiscard]]
-	lazy_task<std::vector<std::reference_wrapper<T>>> when_all(std::vector<task<T&>> tasks)
-	{
-		// First wait until all tasks are ready using non-throwing when_ready().
-		for (auto& t : tasks)
-		{
-			co_await t.when_ready();
-		}
-
-		std::vector<std::reference_wrapper<T>> results;
-		results.reserve(tasks.size());
-
-		for (auto& t : tasks)
-		{
-			results.emplace_back(co_await std::move(t));
-		}
-
-		co_return std::move(results);
-	}
-
 	//////////
 	// when_all() with vector of shared_lazy_task
 
@@ -228,66 +164,6 @@ namespace cppcoro
 
 		co_return std::move(results);
 	}
-
-	//////////
-	// when_all() with vector of shared_task
-
-	[[nodiscard]]
-	inline lazy_task<> when_all(std::vector<shared_task<>> tasks)
-	{
-		// First wait until all tasks are ready.
-		for (auto& t : tasks)
-		{
-			co_await t.when_ready();
-		}
-
-		// Then await the value of the task so that any exceptions
-		// can be rethrown.
-		for (auto& t : tasks)
-		{
-			co_await std::move(t);
-		}
-	}
-
-	template<typename T>
-	[[nodiscard]]
-	lazy_task<std::vector<T>> when_all(std::vector<shared_task<T>> tasks)
-	{
-		for (auto& t : tasks)
-		{
-			co_await t.when_ready();
-		}
-
-		std::vector<T> results;
-		results.reserve(tasks.size());
-
-		for (auto& t : tasks)
-		{
-			results.emplace_back(co_await std::move(t));
-		}
-
-		co_return std::move(results);
-	}
-
-	template<typename T>
-	[[nodiscard]]
-	lazy_task<std::vector<std::reference_wrapper<T>>> when_all(std::vector<shared_task<T&>> tasks)
-	{
-		for (auto& t : tasks)
-		{
-			co_await t.when_ready();
-		}
-
-		std::vector<std::reference_wrapper<T>> results;
-		results.reserve(tasks.size());
-
-		for (auto& t : tasks)
-		{
-			results.emplace_back(co_await std::move(t));
-		}
-
-		co_return std::move(results);
-	}
 }
 
 #endif

include/cppcoro/when_all_ready.hpp

@@ -7,8 +7,6 @@
 
 #include <cppcoro/lazy_task.hpp>
 #include <cppcoro/shared_lazy_task.hpp>
-#include <cppcoro/shared_task.hpp>
-#include <cppcoro/task.hpp>
 
 #include <cppcoro/detail/when_all_awaitable.hpp>
 
@@ -76,19 +74,6 @@ namespace cppcoro
 		co_return std::move(tasks);
 	}
 
-	template<typename T>
-	[[nodiscard]]
-	lazy_task<std::vector<task<T>>> when_all_ready(std::vector<task<T>> tasks)
-	{
-		// All tasks already started, so just wait until they're all done.
-		for (auto& t : tasks)
-		{
-			co_await t.when_ready();
-		}
-
-		co_return std::move(tasks);
-	}
-
 	template<typename T>
 	[[nodiscard]]
 	lazy_task<std::vector<shared_lazy_task<T>>> when_all_ready(std::vector<shared_lazy_task<T>> tasks)
@@ -116,19 +101,6 @@ namespace cppcoro
 
 		co_return std::move(tasks);
 	}
-
-	template<typename T>
-	[[nodiscard]]
-	lazy_task<std::vector<shared_task<T>>> when_all_ready(std::vector<shared_task<T>> tasks)
-	{
-		// All tasks already started, so just wait until each one of them is done.
-		for (auto& t : tasks)
-		{
-			co_await t.when_ready();
-		}
-
-		co_return std::move(tasks);
-	}
 }
 
 #endif

test/build.cake

@@ -28,9 +28,7 @@ sources = script.cwd([
   'cancellation_token_tests.cpp',
   'lazy_task_tests.cpp',
   'shared_lazy_task_tests.cpp',
-  'shared_task_tests.cpp',
   'sync_wait_tests.cpp',
-  'task_tests.cpp',
   'when_all_tests.cpp',
   'when_all_ready_tests.cpp',
 ])