Skip to content

Commit

Permalink
Use JSON string for dictionary example (elastic#15898)
Browse files Browse the repository at this point in the history
Some versions of python cannot guarantee order of dictionaries, so same
dictionary can generate different documentation strings. Use a JSON
string so its representation doesn't depend on how python encodes it.

Also, fix versions in python-env for root directory.
  • Loading branch information
jsoriano authored Jan 28, 2020
1 parent 81dc244 commit 8344dd9
Show file tree
Hide file tree
Showing 18 changed files with 18 additions and 20 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ notice: python-env
.PHONY: python-env
python-env:
@test -d $(PYTHON_ENV) || ${PYTHON_EXE} -m venv $(VENV_PARAMS) $(PYTHON_ENV)
@$(PYTHON_ENV)/bin/pip install -q --upgrade pip autopep8==1.3.5 pylint==1.9.5 future==0.18.2
@$(PYTHON_ENV)/bin/pip install -q --upgrade pip autopep8==1.3.5 pylint==2.4.4
@# Work around pip bug. See: https://github.com/pypa/pip/issues/4464
@find $(PYTHON_ENV) -type d -name dist-packages -exec sh -c "echo dist-packages > {}.pth" ';'

Expand Down
2 changes: 1 addition & 1 deletion auditbeat/docs/fields.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -2949,7 +2949,7 @@ Example: `docker` and `k8s` labels.
type: object
example: {'application': 'foo-bar', 'env': 'production'}
example: { "application": "foo-bar", "env": "production" }
--
Expand Down
2 changes: 1 addition & 1 deletion auditbeat/include/fields.go

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion filebeat/docs/fields.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -5322,7 +5322,7 @@ Example: `docker` and `k8s` labels.
type: object
example: {'application': 'foo-bar', 'env': 'production'}
example: { "application": "foo-bar", "env": "production" }
--
Expand Down
2 changes: 1 addition & 1 deletion filebeat/include/fields.go

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion heartbeat/docs/fields.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -382,7 +382,7 @@ Example: `docker` and `k8s` labels.
type: object
example: {'application': 'foo-bar', 'env': 'production'}
example: { "application": "foo-bar", "env": "production" }
--
Expand Down
2 changes: 1 addition & 1 deletion heartbeat/include/fields.go

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion journalbeat/docs/fields.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -949,7 +949,7 @@ Example: `docker` and `k8s` labels.
type: object
example: {'application': 'foo-bar', 'env': 'production'}
example: { "application": "foo-bar", "env": "production" }
--
Expand Down
2 changes: 1 addition & 1 deletion journalbeat/include/fields.go

Large diffs are not rendered by default.

4 changes: 1 addition & 3 deletions libbeat/_meta/fields.ecs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,7 @@
All values are stored as keyword.
Example: `docker` and `k8s` labels.'
example:
application: foo-bar
env: production
example: '{ "application": "foo-bar", "env": "production" }'
- name: message
level: core
type: text
Expand Down
2 changes: 1 addition & 1 deletion metricbeat/docs/fields.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -6810,7 +6810,7 @@ Example: `docker` and `k8s` labels.
type: object
example: {'application': 'foo-bar', 'env': 'production'}
example: { "application": "foo-bar", "env": "production" }
--
Expand Down
2 changes: 1 addition & 1 deletion metricbeat/include/fields/fields.go

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion packetbeat/docs/fields.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -2162,7 +2162,7 @@ Example: `docker` and `k8s` labels.
type: object
example: {'application': 'foo-bar', 'env': 'production'}
example: { "application": "foo-bar", "env": "production" }
--
Expand Down
2 changes: 1 addition & 1 deletion packetbeat/include/fields.go

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion winlogbeat/docs/fields.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ Example: `docker` and `k8s` labels.
type: object
example: {'application': 'foo-bar', 'env': 'production'}
example: { "application": "foo-bar", "env": "production" }
--
Expand Down
2 changes: 1 addition & 1 deletion winlogbeat/include/fields.go

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion x-pack/functionbeat/docs/fields.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,7 @@ Example: `docker` and `k8s` labels.
type: object
example: {'application': 'foo-bar', 'env': 'production'}
example: { "application": "foo-bar", "env": "production" }
--
Expand Down
2 changes: 1 addition & 1 deletion x-pack/functionbeat/include/fields.go

Large diffs are not rendered by default.

0 comments on commit 8344dd9

Please sign in to comment.