Leventov/pr 705 #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t TypeReference-building factory methods return references with unnamed package rather than null package and null declaring type, to preserve invariant that either ref.getPackage() or ref.getDeclaringType() is not null, unless the type reference represent a primitive type class or void.class
Before this PR, aClass.getReferencedTypes() in the test case testAnonymousClassesHaveAnEmptyStringForItsNameInNoClasspath returns 7 items because the reference A was referenced twice in the sample class. Now, these references are same and we return a Set so we don't have any more two references for A.
leventov
force-pushed
the
pr_705
branch
3 times, most recently
from
bebf5a2 to
b0ec3a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.