fix: Remove document truncation and replace DB inserts with upserts #973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahwooders
changed the title
cpacker
approved these changes
Feb 9, 2024
3 tasks
norton120
pushed a commit
to norton120/MemGPT
that referenced
this pull request
Feb 15, 2024
mattzh72
pushed a commit
that referenced
this pull request
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repeatedly running
memgpt load...or/attachwould result in PostgreSQL errors and/or duplicated data. ThePassage.idfield has been updated to be a hash of the text, and if there already exists that IDinsertandinsert_manywill do an upsert unless otherwise specified.Relevant issues: #949
Note that the current implementation of
insert_manyis very hacky as it uses a different insert method forPassageobjects versus everything else -- eventually we should try to clean this up, perhaps by moving to pydantic/sqlmodel.