Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Update the pytest script to cache poetry artifacts, so tests finish faster #843

Merged
merged 2 commits into from
Jan 18, 2024

Conversation

robbyt
Copy link
Contributor

@robbyt robbyt commented Jan 18, 2024

Please describe the purpose of this pull request.

This change adds a 3rd party action, from here:
https://github.com/marketplace/actions/setup-and-cache-python-poetry

This change will reduce test runtime, because python packages will not need to be downloaded every time this test runs. This will also improve the reliability of tests, because tests will continue working if Pypi becomes unavailable.

How to test
n/a

Have you tested this PR?
n/a

Related issues or PRs
n/a

Is your PR over 500 lines of code?
n/a

Additional context
I am happy to update this to not use a 3rd party action if you prefer.

@cpacker cpacker self-requested a review January 18, 2024 01:30
Copy link
Collaborator

@cpacker cpacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you! Failing tests should be fine/patched on main.

@cpacker cpacker merged commit 00428c6 into letta-ai:main Jan 18, 2024
2 of 3 checks passed
@robbyt robbyt deleted the rterhaar/poetry_cache branch January 18, 2024 03:16
norton120 pushed a commit to norton120/MemGPT that referenced this pull request Feb 15, 2024
mattzh72 pushed a commit that referenced this pull request Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants